Skip to content

Comments

chore: add clean and clean:all script#9435

Merged
reidbarber merged 1 commit intoadobe:mainfrom
unional:clean-and-all
Jan 5, 2026
Merged

chore: add clean and clean:all script#9435
reidbarber merged 1 commit intoadobe:mainfrom
unional:clean-and-all

Conversation

@unional
Copy link
Contributor

@unional unional commented Jan 3, 2026 •
edited
Loading

One improvements on #9426

Adding yarn clean and yarn clean:all to make the script make clean and make clean_all more easily discovered and use.

Another way is to update the CONTRIBUTION.md to point out or list the make commands from the Makefile.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Run yarn clean and yarn clean:all

🧢 Your Project:

snowystinger
snowystinger approved these changes Jan 3, 2026
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought maybe we shouldn't have script targets that called make since that won't work on some machines, but it looks like build does it, so I think it's fine.

Thanks!

@unional
Copy link
Contributor Author

unional commented Jan 3, 2026

In general, it would be better to migrate from using Makefile to pure JS/TS solution, as make does not exist in Windows environment. That would allow people using Windows to contribute.

Of course, that's a much bigger undertaking and wouldn't benefit your team much if you are developing solely in Linux or MacOS.

@reidbarber reidbarber added this pull request to the merge queue Jan 5, 2026
Merged via the queue into adobe:main with commit 321f749 Jan 5, 2026
31 checks passed
@unional unional deleted the clean-and-all branch January 20, 2026 20:43
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

No one assigned

Labels

no testing Does not require manual testing during testing session ready for review small review Easy to review PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@unional @snowystinger @reidbarber @yihuiliao